linux-kernel - Re: swsusp initialized after SATA (was Re: swsusp APIC oopsen (was Re: swsusp ooms))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061025084613.4776ef76.akpm@osdl.org>
Date:	Wed, 25 Oct 2006 08:46:13 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Pavel Machek <pavel@....cz>
Cc:	rjw@...k.pl, linux-kernel@...r.kernel.org, greg@...ah.com
Subject: Re: swsusp initialized after SATA (was Re: swsusp APIC oopsen (was
 Re: swsusp ooms))

> On Wed, 25 Oct 2006 12:43:18 +0200 Pavel Machek <pavel@....cz> wrote:
> Hi!
> 
> > > > (cc-ed to public list)
> > > > 
> > > > > Andrew Morton <akpm@...l.org> wrote:
> > > > > 
> > > > > > and I'm not having much luck.  See 
> > > > > > 
> > > > > > http://userweb.kernel.org/~akpm/s5000340.jpg and
> > > > > > http://userweb.kernel.org/~akpm/s5000339.jpg
> > > > > 
> > > > > Running an UP kernel and disabling local APIC avoided the oopses and
> > > > > allowed me to confirm that it was leaking.  whoops.
> > > > 
> > > > I wonder why everyone but me sees those APIC problems?
> > > > 
> > > > Anyway, there's one more problem in -rc1: boot order changed, and (at
> > > > least with paralel boot options), swsusp gets initialized *after*
> > > > swsusp => bad, but should be easy to fix.
> > > 
> > > Sorry, I meant:
> > > 
> > > "sata is initialized *after* swsusp => bad".
> > 
> > Which patch made this change, and why?
> 
> CONFIG_PCI_MULTITHREAD_PROBE is the setting responsible, and IIRC
> that's Greg's code.
> 
> Now... what is the recommended way to wait for hard disks to become
> online?

The multithreaded probing is breaking (or at least altering) the initcall
ordering guarantees.  We should wait for all the probing kernel threads to
terminate after processing each initcall level.  

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/