linux-kernel - Re: [PATCH] x86_64 irq: reset more to default when clear irq_vector for destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440610242301te23d733g9d73402303c76135@mail.gmail.com>
Date:	Tue, 24 Oct 2006 23:01:24 -0700
From:	yhlu <yhlu.kernel@...il.com>
To:	"David Rientjes" <rientjes@...washington.edu>
Cc:	"Andi Kleen" <ak@....de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Andrew Morton" <akpm@...l.org>,
	"Muli Ben-Yehuda" <muli@...ibm.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64 irq: reset more to default when clear irq_vector for destroy_irq

I cut the code paste the lines from __assign_irq_vector().

It seems we need to change
    if (old_vector >= 0) {
in __assign_irq_vector with this one to
    if (old_vector > 0) {
later.   Eric?

YH




> The two conditionals don't complement each other; in fact, only one
> conditional is required since the test for old_vector equality to zero
> will never be satisfied.  Also note that irq_vectors are u8 on x86_64 and
> not ints.
>
>         static void __clear_irq_vector(int irq)
>         {
>                 u8 old_vector = irq_vector[irq];
>                 if (old_vector > 0) {
>                         cpumask_t old_mask;
>                         int old_cpu;
>                         cpus_and(old_mask, irq_domain[irq], cpu_online_map);
>                         for_each_cpu_mask(old_cpu, old_mask)
>                                 per_cpu(vector_irq, old_cpu)[old_vector] = -1;
>                 }
>                 irq_vector[irq] = 0;
>                 irq_domain[irq] = CPU_MASK_NONE;
>         }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/