| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Oct 2006 09:52:38 +0200
From: Heiko Carstens <heiko.carstens@...ibm.com>
To: arnd@...db.de
Cc: cbe-oss-dev@...abs.org, linuxppc-dev@...abs.org,
linux-kernel@...r.kernel.org, paulus@...ba.org
Subject: Re: [PATCH 11/16] sysfs: add support for adding/removing spu sysfs attributes
> +int cpu_add_sysdev_attr(struct sysdev_attribute *attr)
> +{
> + int cpu;
> +
> + mutex_lock(&cpu_mutex);
> +
> + for_each_possible_cpu(cpu) {
> + sysdev_create_file(get_cpu_sysdev(cpu), attr);
> + }
> +
> + mutex_unlock(&cpu_mutex);
> + return 0;
> +}
You probably should check for errors on sysdev_create_file, clean up and
return an error number instead of always 0.
This is true for all the new functions here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists