linux-kernel - Re: [PATCH] strstrip remove last blank fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610261420200.1223@sbz-30.cs.Helsinki.FI>
Date:	Thu, 26 Oct 2006 14:20:56 +0300 (EEST)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	Michael Holzheu <holzheu@...ibm.com>
cc:	linux-kernel@...r.kernel.org, akpm@...l.org,
	joern@...nheim.fh-wedel.de, schwidefsky@...ibm.com,
	ioe-lkml@...eria.de, minyard@....org
Subject: Re: [PATCH] strstrip remove last blank fix

On Thu, 26 Oct 2006, Michael Holzheu wrote:
> strstrip() does not remove the last blank from strings which only consist
> of blanks.

[snip]

> Acked-by: Martin Schwidefsky <schwidefsky@...ibm.com>
> Signed-off-by: Michael Holzheu <holzheu@...ibm.com>
> 
> ---
> 
>  lib/string.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -Naurp linux-2.6.18/lib/string.c linux-2.6.18-strstrip-fix/lib/string.c
> --- linux-2.6.18/lib/string.c	2006-06-19 14:03:20.000000000 +0200
> +++ linux-2.6.18-strstrip-fix/lib/string.c	2006-10-25 18:36:08.000000000 +0200
> @@ -320,7 +320,7 @@ char *strstrip(char *s)
>  		return s;
>  
>  	end = s + size - 1;
> -	while (end != s && isspace(*end))
> +	while (end >= s && isspace(*end))
>  		end--;
>  	*(end + 1) = '\0';

Looks good, thanks!  Andrew, can you please pick up this patch?

Acked-by: Pekka Enberg <penberg@...helsinki.fi>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/