linux-kernel - Re: [PATCH] time_adjust cleared before use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610261919400.6761@scrub.home>
Date:	Thu, 26 Oct 2006 19:22:27 +0200 (CEST)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Jim Houston <jim.houston@...cast.net>
cc:	John Stultz <johnstul@...ibm.com>, linux-kernel@...r.kernel.org,
	linux@...izon.com
Subject: Re: [PATCH] time_adjust cleared before use

Hi,

On Thu, 26 Oct 2006, Jim Houston wrote:

> Hi
> 
> I notice that the code which implements adjtime clears
> the time_adjust value before using it.  The attached 
> patch makes the obvious fix.
> 
> Jim Houston - Concurrent Computer Corp.
> 
> --
> 
> diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
> index 47195fa..3afeaa3 100644
> --- a/kernel/time/ntp.c
> +++ b/kernel/time/ntp.c
> @@ -161,9 +161,9 @@ void second_overflow(void)
>  			time_adjust += MAX_TICKADJ;
>  			tick_length -= MAX_TICKADJ_SCALED;
>  		} else {
> -			time_adjust = 0;
>  			tick_length += (s64)(time_adjust * NSEC_PER_USEC /
>  					     HZ) << TICK_LENGTH_SHIFT;
> +			time_adjust = 0;
>  		}
>  	}
>  }

Acked-by: Roman Zippel <zippel@...ux-m68k.org>

Thanks, that might also explain the other problem.
Could you please sign it off and then it should go into 2.6.19.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/