[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0610261158130.2802@schroedinger.engr.sgi.com>
Date: Thu, 26 Oct 2006 12:00:30 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
cc: LKML <linux-kernel@...r.kernel.org>,
ppc-dev <linuxppc-dev@...abs.org>, paulus@...ba.org, ak@...e.de,
linux-mm@...ck.org
Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages
On Thu, 26 Oct 2006, Stephen Rothwell wrote:
> This is needed on bigendian 64bit architectures. The obvious way to do
> this (taking the other compat_ routines in this file as examples) is to
> use compat_alloc_user_space and copy the bitmasks back there, however you
> cannot call compat_alloc_user_space twice for a single system call and
> this method saves two copies of the bitmasks.
Well this means also that sys_mbind and sys_set_mempolicy are also
broken because these functions also use get_nodes().
Fixing get_nodes() to do the proper thing would fix all of these
without having to touch sys_migrate_pages or creating a compat_ function
(which usually is placed in kernel/compat.c)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists