linux-kernel - Re: [PATCH cciss: fix printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061026160245.26f86ce2.akpm@osdl.org>
Date:	Thu, 26 Oct 2006 16:02:45 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	iss_storagedev@...com, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH cciss: fix printk format warning

On Mon, 23 Oct 2006 21:46:08 -0700
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> --- linux-2619-rc3-pv.orig/drivers/block/cciss.c
> +++ linux-2619-rc3-pv/drivers/block/cciss.c
> @@ -1992,8 +1992,8 @@ cciss_read_capacity(int ctlr, int logvol
>  		*block_size = BLOCK_SIZE;
>  	}
>  	if (*total_size != (__u32) 0)

Why is cciss_read_capacity casting *total_size to u32?

It is a sector_t.  If it happens to have the value 0xnnnnnnnn00000000 then
this expression will incorrectly evaluate to `false'.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/