linux-kernel - Re: [PATCH cciss: fix printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada1wou7i4p.fsf@cisco.com>
Date:	Thu, 26 Oct 2006 16:49:10 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Andrew Morton <akpm@...l.org>, iss_storagedev@...com,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH cciss: fix printk format warning

 > OK, how about this one then?
 > 
 > 	c->busaddr = (__u32) cmd_dma_handle;
 > 
 > where cmd_dma_handle is a dma_addr_t (u32 or u64)

It's super-fishy looking but actually I think it's OK, at least as
things stand now.  As you see later from how it's freed:

 > 		pci_free_consistent(h->pdev, sizeof(CommandList_struct),
 > 				    c, (dma_addr_t) c->busaddr);

this is the bus address of memory from pci_alloc_consistent(), and
since cciss never does pci_set_consistent_dma_mask(), the mask will
remain at the default 32 bits.  So the driver is actually safe in
assuming that cmd_dma_handle fits into 32 bits.  assuming that
cmd_dma_handle.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/