linux-kernel - Re: [PATCH] cm4000_cs: fix return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061026102530.GM6264@sunbeam.de.gnumonks.org>
Date:	Thu, 26 Oct 2006 12:25:30 +0200
From:	Harald Welte <laforge@...monks.org>
To:	Dominik Brodowski <linux@...inikbrodowski.net>,
	Akinobu Mita <akinobu.mita@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cm4000_cs: fix return value check

On Wed, Oct 25, 2006 at 10:40:04PM -0400, Dominik Brodowski wrote:

> On Tue, Oct 17, 2006 at 03:25:59PM +0900, Akinobu Mita wrote:
> > The return value of class_create() need to be checked with IS_ERR().
> > And register_chrdev() returns errno on failure.
> > This patch includes these fixes for cm4000_cs and cm4040_cs.
> > 
> > Cc: Harald Welte <laforge@...monks.org>
> > Signed-off-by: Akinbou Mita <akinobu.mita@...il.com>
> 
> Temporarily applied to pcmica-2.6.git, thanks. Harald, do you ACK?

yes, sorry.  I've been too busy and the mail slipped through...

The patch is obviously fine. Thanks!

Signed-off-by: Harald Welte <laforge@...monks.org>

-- 
- Harald Welte <laforge@...monks.org>          	        http://gnumonks.org/
============================================================================
We all know Linux is great...it does infinite loops in 5 seconds. -- Linus

Content of type "application/pgp-signature" skipped