linux-kernel - Re: [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Oct 2006 23:24:47 +0200
From:	Jesper Juhl <jesper.juhl@...il.com>
To:	tglx@...utronix.de
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Steven J.Hill" <sjhill@...litydiluted.com>,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485

On Thursday 26 October 2006 07:27, Thomas Gleixner wrote:
> On Thu, 2006-10-26 at 01:43 +0200, Jesper Juhl wrote:
> > 'make xmldocs' currently gives me this warning :
> > 
> >     Warning(/home/juhl/download/kernel/linux-2.6//drivers/mtd/nand/nand_base.c:1485): No description found for parameter 'raw'
> > 
> > This patch silences the warning by adding a description for 'raw'
> > 
> > 
> > Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> 
> ACK
> 	tglx
> 
Thank you for the ACK Thomas.

Linus: Could you add this to your tree?  I believe it's still appropriate even at -rc3 since it doesn't make any code changes but simply fix an annoying warning.
Patch included (again) below for your convenience : 


Add description of 'raw' in comments for 
drivers/mtd/nand/nand_base.c::nand_write_page_syndrome() so 'make xmldocs' 
will not spew a warning at us.

Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
---

 drivers/mtd/nand/nand_base.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index baece61..41bfcae 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -1479,6 +1479,7 @@ static void nand_write_page_syndrome(str
  * @buf:	the data to write
  * @page:	page number to write
  * @cached:	cached programming
+ * @raw:	use _raw version of write_page
  */
 static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
 			   const uint8_t *buf, int page, int cached, int raw)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/