linux-kernel - [PATCH] Fix bug in fs/ecryptfs/inode.c: ecryptfs_encode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4541B9E8.2030402@gmail.com>
Date:	Fri, 27 Oct 2006 10:48:56 +0300
From:	Mika Kukkonen <mikukkon@...il.com>
To:	ecryptfs-devel@...ts.sourceforge.net
CC:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: [PATCH] Fix bug in fs/ecryptfs/inode.c: ecryptfs_encode_filename()
 returns int, not unsigned int

[PATCH] Fix bug in fs/ecryptfs/inode.c: ecryptfs_encode_filename()
        returns int (with possible negative error value), not
        unsigned int. Both callers in the file get it wrong (they
        are also the only callers of this function). Found by gcc
        extra warning flags (the return value is checked to be < 0,
        which is pointless with unsigned). Compile tested only, but
        should be OK, as the value computed in the function
        internally is int too.

Signed-off-by: Mika Kukkonen <mikukkon@....fi>

---

 fs/ecryptfs/inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index efdd2b7..692419c 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -338,7 +338,7 @@ static struct dentry *ecryptfs_lookup(st
     struct vfsmount *lower_mnt;
     struct dentry *tlower_dentry = NULL;
     char *encoded_name;
-    unsigned int encoded_namelen;
+    int encoded_namelen;
     struct ecryptfs_crypt_stat *crypt_stat = NULL;
     char *page_virt = NULL;
     struct inode *lower_inode;
@@ -520,7 +520,7 @@ static int ecryptfs_symlink(struct inode
     struct dentry *lower_dir_dentry;
     umode_t mode;
     char *encoded_symname;
-    unsigned int encoded_symlen;
+    int encoded_symlen;
     struct ecryptfs_crypt_stat *crypt_stat = NULL;

     lower_dentry = ecryptfs_dentry_to_lower(dentry);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/