[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9a8748490610281007s7964f0e6nd3982ed1882264f9@mail.gmail.com>
Date: Sat, 28 Oct 2006 19:07:37 +0200
From: "Jesper Juhl" <jesper.juhl@...il.com>
To: "Randy Dunlap" <randy.dunlap@...cle.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
torvalds <torvalds@...l.org>, akpm <akpm@...l.org>
Subject: Re: [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485
On 28/10/06, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> On Fri, 27 Oct 2006 22:59:03 GMT Linux Kernel Mailing List wrote:
>
> > commit efbfe96c5d839c367249bf1cd53249716450c0a2
> > tree 36a1a7d72586a2f8fd25feb225cd4e627cd275b3
> > parent 735a7ffb739b6efeaeb1e720306ba308eaaeb20e
> > author Jesper Juhl <jesper.juhl@...il.com> 1161984287 +0200
> > committer Linus Torvalds <torvalds@...osdl.org> 1161988491 -0700
> >
> > [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485
> >
> > Add description of 'raw' in comments for
> > drivers/mtd/nand/nand_base.c::nand_write_page_syndrome() so 'make xmldocs'
> > will not spew a warning at us.
> >
> > Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> > Acked-by: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Linus Torvalds <torvalds@...l.org>
> >
> > drivers/mtd/nand/nand_base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index baece61..41bfcae 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> > @@ -1479,6 +1479,7 @@ static void nand_write_page_syndrome(str
> > * @buf: the data to write
> > * @page: page number to write
> > * @cached: cached programming
> > + * @raw: use _raw version of write_page
> > */
> > static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
> > const uint8_t *buf, int page, int cached, int raw)
> > -
>
> Hi Jesper,
> I'm still seeing a kernel-doc warning in include/linux/mtd/nand.h.
> Do you not see it also?
>
I see it, simply got distracted when doing the patch and forgot about it.
> Patch is here:
> http://marc.theaimsgroup.com/?l=linux-mm-commits&m=116189778426861&w=2
>
Looks good.
--
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists