linux-kernel - Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061027215037.cd69b2a3.akpm@osdl.org>
Date:	Fri, 27 Oct 2006 21:50:37 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Pavel Machek <pavel@....cz>, Rusty Russell <rusty@...tcorp.com.au>,
	virtualization <virtualization@...ts.osdl.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS
 address space

On Fri, 27 Oct 2006 21:33:08 -0700
Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Andrew Morton wrote:
> > It'd be better to use include/linux/uaccess.h:probe_kernel_address() for
> > this operation.
> >   
> Ah, yes, that was the precedent I was thinking of,

We've done open-coded __get_user() in various places in the past.  The difference with
probe_kernel_address() is that it doesn't get deadlocked on mmap_sem().

>  but I guess it would 
> be better to just use it directly.  It's a relatively new interface, 
> isn't it?

Yeah.  New enough that nobody's tried using it on non-x86 ;) It needs
to do set_fs(KERNEL_DS).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/