linux-kernel - Re: -W -Wno-unused -Wno-sign-compare compile flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200610291639.k9TGdV6E011416@turing-police.cc.vt.edu>
Date:	Sun, 29 Oct 2006 11:39:31 -0500
From:	Valdis.Kletnieks@...edu
To:	predator@....ru
Cc:	linux-kernel@...r.kernel.org
Subject: Re: -W -Wno-unused -Wno-sign-compare compile flags

On Sun, 29 Oct 2006 17:22:48 +0300, predator@....ru said:
> Hello !linux-kernel
> 
> Does anybody try to compile latest linux-kernel with -W 
> -Wno-unused -Wno-sign-compare CFLAGS? There is a tons of 
> warnings :(
> Recent versions of grsecurity patches adds this flags to 
> default. When I asked to grsec developers, why did they do 
> that, they answered: to show, how messy linux code is...
> Is there any objections about it?

I'd recommend attacking this one flag at a time - so for instance,
do up a series of patches that cleans up the -Wno-unused warnings, and
get that merged.  Then get a series for -Wno-sign-compare, and finally
a patch that adds -W.

While you're at it, look at these flags as well:

-Werror-implicit-function-declaration -Wcomment -Wendif-labels -Wshadow

(The tree is pretty clean for the first 3, cleaning it for the last will
take some work...)

Content of type "application/pgp-signature" skipped