[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0610300659370.7577@localhost.localdomain>
Date: Mon, 30 Oct 2006 07:03:10 -0500 (EST)
From: "Robert P. J. Day" <rpjday@...dspring.com>
To: Al Viro <viro@....linux.org.uk>
cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
trivial@...nel.org
Subject: Re: [PATCH] semaphore.h: add missing "sleepers = 0" initialization
On Mon, 30 Oct 2006, Al Viro wrote:
> On Mon, Oct 30, 2006 at 05:43:14AM -0500, Robert P. J. Day wrote:
> >
> > Add the missing initialization of "sleepers" to 0 in two semaphore
> > initialization macros.
>
> Umm... What the hell for? Both for struct initializer and for
> compound literals all named fields that had not been mentioned get
> initialized as they would for static objects. So that's simply
> adding more work to parser for no reason whatsoever.
i did that simply to make those initializations *consistent* across
all of the other dozen or so semaphore.h files that *do* explicitly
initialize that structure member (as you point out, for no good
reason). i'm just as happy to whack out all of those useless
initializations, though, and submit another patch. either way works
for me.
rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists