linux-kernel - Re: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200610291806.56131.david-b@pacbell.net>
Date:	Sun, 29 Oct 2006 19:06:50 -0700
From:	David Brownell <david-b@...bell.net>
To:	Pierre Ossman <drzeus-list@...eus.cx>
Cc:	Carlos Aguiar <carlos.aguiar@...t.org.br>,
	linux-kernel@...r.kernel.org,
	linux-omap-open-source@...ux.omap.com,
	Tony Lindgren <tony@...mide.com>,
	Russell King <rmk+lkml@....linux.org.uk>,
	ilias.biris@...t.org.br
Subject: Re: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V5

On Sunday 29 October 2006 1:49 am, Pierre Ossman wrote:

> > +	data_buf = kmalloc(data_size, GFP_KERNEL);
> >   
> 
> For something that can be at most 34 bytes, a kmalloc seems excessive.
> Put it on the stack. Just remember to have checks so we do not overflow.

It does seem excessive, but stack-allocated buffers are not guaranteed
to be DMA-safe.  See Documentation/DMA-mapping.txt right in the first
major section "What memory is DMA'able?"...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/