lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Oct 2006 19:18:35 +0530 From: Balbir Singh <balbir@...ibm.com> To: Andrew Morton <akpm@...l.org>, "Martin T. Setek" <martitse@....uio.no> CC: Shailabh Nagar <nagar@...son.ibm.com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: Fw: [PATCH: 2.6.18.1] delayacct: cpu_count in taskstats updated correctly > Begin forwarded message: > > Date: Fri, 27 Oct 2006 05:18:17 +0200 (CEST) > From: Martin Tostrup Setek <martitse@...dent.matnat.uio.no> > To: nagar@...son.ibm.com > Cc: linux-kernel@...r.kernel.org > Subject: [PATCH: 2.6.18.1] delayacct: cpu_count in taskstats updated correctly > > > from: Martin T. Setek <martitse@....uio.no> > > cpu_count in struct taskstats should be the same as the corresponding > (third) value found in /proc/<pid>/schedstat > Signed-off-by: <martitse@....uio.no> > --- > Index: linux-2.6.18.1/kernel/delayacct.c > =================================================================== > --- linux-2.6.18.1.orig/kernel/delayacct.c > +++ linux-2.6.18.1/kernel/delayacct.c > @@ -124,7 +124,7 @@ int __delayacct_add_tsk(struct taskstats > t2 = tsk->sched_info.run_delay; > t3 = tsk->sched_info.cpu_time; > > - d->cpu_count += t1; > + d->cpu_count = t1; > > jiffies_to_timespec(t2, &ts); > tmp = (s64)d->cpu_delay_total + timespec_to_ns(&ts); > - I was off from work and just saw this message. The first field "d" in __delayacct_add_task() acts as an accumulator of statistics (specially useful for fill_tgid() and called just once for fill_pid() with cpu_count of "d" initialized to 0). We sum up in d->cpu_count, since the same value of "d" is passed each time from fill_tgid(). The proposed change is incorrect as we would overwrite the value each time. Balbir -- Balbir Singh, Linux Technology Center, IBM Software Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists