linux-kernel - Re: [PATCH 2.6.18-mm2] acpi: add backlight support to the sony

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 30 Oct 2006 23:49:17 +0800
From:	"Luming Yu" <luming.yu@...il.com>
To:	"Pavel Machek" <pavel@....cz>
Cc:	"Matt Domsch" <Matt_Domsch@...l.com>, len.brown@...el.com,
	"Richard Hughes" <hughsient@...il.com>,
	"Andrew Morton" <akpm@...l.org>,
	"Alessandro Guido" <alessandro.guido@...il.com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	jengelh@...ux01.gwdg.de, gelma@...ma.net, ismail@...dus.org.tr
Subject: Re: [PATCH 2.6.18-mm2] acpi: add backlight support to the sony_acpi driver

updated version attached.

signed-off-by   Luming.yu@...il.com

[patch 1/6] video sysfs support: Add dev argument for backlight sys dev
 drivers/video/backlight/backlight.c |    7 +++++--
 include/linux/backlight.h           |    2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

patch 2/6] Add display output class support
 drivers/video/output.c |  129 +++++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/output.h |   42 +++++++++++++++
 2 files changed, 171 insertions(+)

[patch 3/6] backlight and output sysfs support for acpi video driver
 acpi/Kconfig   |    2
 acpi/video.c   |  257 +++++++++++++++++++++++++++++++++++++++++++++++++++++----
 video/Kconfig  |    9 +
 video/Makefile |    1
 4 files changed, 253 insertions(+), 16 deletions(-)

[patch 4/6] Add output class document
 video-output.txt |   34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

[patch 5/6] fix comments style
 video.c |   44 ++++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

[patch 6/6] fix compile time warning
 video.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


On 10/30/06, Pavel Machek <pavel@....cz> wrote:
> Hi!
>
> > > Some whitespace is not okay there...
> > >                                                                     Pavel
> >
> > updated version.
>
> > index 27597c5..1a18cdb 100644
> > --- a/drivers/video/backlight/backlight.c
> > +++ b/drivers/video/backlight/backlight.c
> > @@ -190,7 +190,7 @@ static int fb_notifier_callback(struct n
> >   * Creates and registers new backlight class_device. Returns either an
> >   * ERR_PTR() or a pointer to the newly allocated device.
> >   */
> > -struct backlight_device *backlight_device_register(const char *name, void *devdata,
> > +struct backlight_device *backlight_device_register(const char *name,struct device *dev,  void *devdata,
> >                                                  struct
>
> 80-columns, and fix the whitespace, please.
>
> > --- /dev/null
> > +++ b/drivers/video/output.c
> > @@ -0,0 +1,110 @@
> > +/*
> > + * Video output switch support
> > + */
>
> I guess this one needs copyright/GPL.
>
> > +     struct output_device *new_dev;
> > +     int     ret_code = 0;
>
> Indentation is wrong where...
>
> > +     new_dev = (struct output_device *) kzalloc( sizeof(struct
> output_device), GFP_KERNEL);
>
> Cast should not be needed.
>
> > +     strlcpy(new_dev->class_dev.class_id, name, KOBJ_NAME_LEN);
> > +     class_set_devdata(&new_dev->class_dev, devdata);
> > +     ret_code = class_device_register(&new_dev->class_dev);
> > +     if (ret_code){
>
> ") {", please.
>
> > +             kfree (new_dev);
>
> ..and no space between kfree and its arguments.
>
>
> > @@ -0,0 +1,27 @@
> > +The output sysfs class driver is to provide video output abstract layer that can be used to hook platform specific methods to enable/disable video output device through common sysfs interface.
> > +
>
> 80-columns, please. And some title would be nice.
>
> > @@ -141,11 +144,11 @@ struct acpi_video_device_cap {
> >       u8 _ADR:1;              /*Return the unique ID */
> >       u8 _BCL:1;              /*Query list of brightness control levels supported */
> >       u8 _BCM:1;              /*Set the brightness level */
> > +     u8 _BQC:1;              /*Get current brightness level */
> >       u8 _DDC:1;              /*Return the EDID for this device */
> >       u8 _DCS:1;              /*Return status of output device */
> >       u8 _DGS:1;              /*Query graphics state */
> >       u8 _DSS:1;              /*Device state set */
>
> It is nicer to have space between /* and comment.
>                                                                 Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>

View attachment "1-fix.patch" of type "text/x-patch" (1622 bytes)

View attachment "2-fix.patch" of type "text/x-patch" (5655 bytes)

View attachment "3-fix.patch" of type "text/x-patch" (15159 bytes)

View attachment "4-fix.patch" of type "text/x-patch" (1317 bytes)

View attachment "5-fix.patch" of type "text/x-patch" (2734 bytes)

View attachment "6-fix.patch" of type "text/x-patch" (826 bytes)