linux-kernel - Re: [PATCH 2/7] severing fs.h, radix-tree.h -> sched.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Oct 2006 08:47:44 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Al Viro <viro@....linux.org.uk>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	torvalds@...l.org
Subject: Re: [PATCH 2/7] severing fs.h, radix-tree.h -> sched.h

Trivial comment:

 >  /*
 > + * Superblock locking.  We really ought to get rid of these two.
 > + */
 > +void lock_super(struct super_block * sb)
 > +{
 > +	get_fs_excl();
 > +	mutex_lock(&sb->s_lock);
 > +}
 > +
 > +void unlock_super(struct super_block * sb)
 > +{
 > +	put_fs_excl();
 > +	mutex_unlock(&sb->s_lock);
 > +}
 > +
 > +EXPORT_SYMBOL(lock_super);
 > +EXPORT_SYMBOL(unlock_super);

isn't the current fashion to do this like:

void lock_super(struct super_block * sb)
{
	get_fs_excl();
	mutex_lock(&sb->s_lock);
}
EXPORT_SYMBOL(lock_super);

void unlock_super(struct super_block * sb)
{
	put_fs_excl();
	mutex_unlock(&sb->s_lock);
}
EXPORT_SYMBOL(unlock_super);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/