linux-kernel - Re: [BUG] dmsetup table output changed from 2.6.18 to 2.6.19-rc3 and breaks yaird.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061030191554.GN1319@agk.surrey.redhat.com>
Date:	Mon, 30 Oct 2006 19:15:54 +0000
From:	Alasdair G Kergon <agk@...hat.com>
To:	Linus Torvalds <torvalds@...l.org>
Cc:	herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	dm-devel@...hat.com, dm-crypt@...ut.de,
	Christophe Saout <christophe@...ut.de>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [BUG] dmsetup table output changed from 2.6.18 to 2.6.19-rc3 and breaks yaird.

On Mon, Oct 30, 2006 at 11:00:29AM -0800, Linus Torvalds wrote:
> (maybe something like this trivial one? Totally untested, but it would 
> seem to be the sane approach)
 
> diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
> index a625576..645e3ce 100644
> --- a/drivers/md/dm-crypt.c
> +++ b/drivers/md/dm-crypt.c
> @@ -925,8 +925,7 @@ static int crypt_status(struct dm_target
>  		break;
>  
>  	case STATUSTYPE_TABLE:
> -		cipher = crypto_blkcipher_name(cc->tfm);
> -
> +		cipher = cc->cipher;
>  		chainmode = cc->chainmode;
>  
>  		if (cc->iv_mode)
> 
> 

Looks correct.

The point of STATUSTYPE_TABLE is to return (readable) output to userspace in
a format that the crypt_ctr() function would accept back in.

So crypt_ctr() now stores a private copy of cipher and chainmode for
crypt_status() to regurgitate when requested.

Alasdair
-- 
agk@...hat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/