linux-kernel - Re: [PATCH] vmalloc : optimization, cleanup, bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <45466A1A.706@cosmosbay.com>
Date:	Mon, 30 Oct 2006 22:09:46 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Zwane Mwaikambo <zwane@...radead.org>
Cc:	Nick Piggin <nickpiggin@...oo.com.au>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmalloc : optimization, cleanup, bugfixes

Zwane Mwaikambo a écrit :
> On Mon, 23 Oct 2006, Nick Piggin wrote:
> 
>> Eric Dumazet wrote:
>>> [PATCH] vmalloc : optimization, cleanup, bugfixes
>>>
>>> This patch does three things
>>>
>>> 1) reorder 'struct vm_struct' to speedup lookups on CPUS with small cache
>>> lines. The fields 'next,addr,size' should be now in the same cache line, to
>>> speedup lookups.
>>>
>>> 2) One minor cleanup in __get_vm_area_node()
>>>
>>> 3) Bugfixes in vmalloc_user() and vmalloc_32_user()
>>> NULL returns from __vmalloc() and __find_vm_area() were not tested.
>> Hmm, so they weren't. As far as testing the return of __find_vm_area,
>> you can just turn that into a BUG_ON(!area), because at that point,
>> we've established that the vmalloc succeeded.
> 
> No need for a BUG_ON it'll simply be a NULL dereference, at which point 
> we're back to the original code.

Indeed

This is what Andrew said one week ago :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/