| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20061030.143357.130208425.davem@davemloft.net> Date: Mon, 30 Oct 2006 14:33:57 -0800 (PST) From: David Miller <davem@...emloft.net> To: hch@....de Cc: linux-kernel@...r.kernel.org, netdev@....sgi.com, linux-mm@...ck.org Subject: Re: [PATCH 2/3] add dev_to_node() From: Christoph Hellwig <hch@....de> Date: Mon, 30 Oct 2006 15:15:01 +0100 > Davem suggested to get the node-affinity information directly from > struct device instead of having the caller extreact it from the > pci_dev. This patch adds dev_to_node() to the topology API for that. > The implementation is rather ugly as we need to compare the bus > operations which we can't do inline in a header without pulling all > kinds of mess in. > > Thus provide an out of line dev_to_node for ppc and let everyone else > use the dummy variant in asm-generic.h for now. > > Signed-off-by: Christoph Hellwig <hch@....de> It may be a bit much to be calling all the way through up to the PCI layer just to pluck out a simple integer, don't you think? The PCI bus pointer comparison is just a symptom of how silly this is. Especially since this will be used for every packet allocation a device makes. So, please add some sanity to this situation and just put the node into the generic struct device. :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists