linux-kernel - Re: [PATCH 2.6.19-rc1 update4] drivers: add LCD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Oct 2006 10:35:18 +0100
From:	Franck Bui-Huu <vagabon.xyz@...il.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Miguel Ojeda Sandonis <maxextreme@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19-rc1 update4] drivers: add LCD support

Andrew,

Andrew Morton wrote:
> On Thu, 26 Oct 2006 17:48:58 +0000
> Miguel Ojeda Sandonis <maxextreme@...il.com> wrote:
> 
[snip]
> 
>> +struct page *cfag12864bfb_vma_nopage(struct vm_area_struct *vma,
>> +	unsigned long address, int *type)
> 
> This function can have static scope.
> 
>> +{
>> +	struct page *page;
>> +	down(&cfag12864bfb_sem);
>> +
>> +	page = virt_to_page(cfag12864b_buffer);
>> +	get_page(page);
>> +
>> +	if(type)
>> +		*type = VM_FAULT_MINOR;
>> +
>> +	up(&cfag12864bfb_sem);
>> +	return page;
>> +}
> 

Any idea why LDD3 states:

	An interesting limitation of remap_pfn_range is that it gives
	access only to reserved pages and physical addresses above the
	top of physical memory.

Is that true we can't do:

	buf = (char *)__get_free_page(...);
	pfn = PFN_DOWN(virt_to_phys(buf));
	remap_pfn_range(vma, vma->vm_start, pfn, PAGE_SIZE, vma->vm_page_prot);

Thanks
		Franck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/