linux-kernel - Re: [PATCH 4/4] gfs2: ->readpages() fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1162285005.27980.278.camel@quoit.chygwyn.com>
Date:	Tue, 31 Oct 2006 08:56:45 +0000
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	akpm@...l.org
Subject: Re: [PATCH 4/4] gfs2: ->readpages() fixes

Hi,

On Tue, 2006-10-31 at 05:05 +0900, OGAWA Hirofumi wrote:
> This just ignore the remaining pages, and remove unneeded unlock_pages().
> 
> Signed-off-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Acked-by: Steven Whitehouse <swhiteho@...hat.com>

Thanks for fixing this,

Steve.


> ---
> 
>  fs/gfs2/ops_address.c |    7 -------
>  1 file changed, 7 deletions(-)
> 
> diff -puN fs/gfs2/ops_address.c~readpages-fixes-gfs2 fs/gfs2/ops_address.c
> --- linux-2.6/fs/gfs2/ops_address.c~readpages-fixes-gfs2	2006-10-31 04:26:20.000000000 +0900
> +++ linux-2.6-hirofumi/fs/gfs2/ops_address.c	2006-10-31 04:26:20.000000000 +0900
> @@ -337,13 +337,6 @@ out:
>  out_noerror:
>  	ret = 0;
>  out_unlock:
> -	/* unlock all pages, we can't do any I/O right now */
> -	for (page_idx = 0; page_idx < nr_pages; page_idx++) {
> -		struct page *page = list_entry(pages->prev, struct page, lru);
> -		list_del(&page->lru);
> -		unlock_page(page);
> -		page_cache_release(page);
> -	}
>  	if (do_unlock)
>  		gfs2_holder_uninit(&gh);
>  	goto out;
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/