linux-kernel - Re: [PATCH 2/6] eCryptfs: Hash code to new crypto API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061031010505.GC26146@gondor.apana.org.au>
Date:	Tue, 31 Oct 2006 12:05:05 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Michael Halcrow <mhalcrow@...ibm.com>
Cc:	akpm@...l.org, LKML <linux-kernel@...r.kernel.org>,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH 2/6] eCryptfs: Hash code to new crypto API

On Mon, Oct 30, 2006 at 05:35:29PM -0600, Michael Halcrow wrote:
>
> +	crypto_hash_init(&desc);
> +	crypto_hash_update(&desc, &sg, len);
> +	crypto_hash_final(&desc, dst);

Whenever you do init+update+final, it's preferred that this be
changed to crypto_hash_digest as this enables future optimisations
to be made.  For instance, some hardware can only handle a full
digest rather than a partial update.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/