linux-kernel - Re: [PATCH 3/6] taskstats_tgid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4546B9BC.6020109@in.ibm.com>
Date:	Tue, 31 Oct 2006 08:19:32 +0530
From:	Balbir Singh <balbir@...ibm.com>
To:	Oleg Nesterov <oleg@...sign.ru>
CC:	Andrew Morton <akpm@...l.org>,
	Shailabh Nagar <nagar@...son.ibm.com>, Jay Lan <jlan@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] taskstats_tgid_free: fix usage

Oleg Nesterov wrote:
> taskstats_tgid_free() is called on copy_process's error path. This is wrong.
> 
> 	IF (clone_flags & CLONE_THREAD)
> 		We should not clear ->signal->taskstats, current uses it,
> 		it probably has a valid accumulated info.
> 	ELSE
> 		taskstats_tgid_init() set ->signal->taskstats = NULL,
> 		there is nothing to free.
> 
> Move the callsite to __exit_signal(). We don't need any locking, entire
> thread group is exiting, nobody should have a reference to soon to be
> released ->signal.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

Looks good!
Acked-by: Balbir Singh <balbir@...ibm.com>

---

	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/