linux-kernel - [PATCH] init_reap_node() initialization fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1162328719.12872.39.camel@localhost.localdomain>
Date:	Tue, 31 Oct 2006 16:05:19 -0500
From:	Daniel Yeisley <dan.yeisley@...sys.com>
To:	linux-kernel@...r.kernel.org
Cc:	ak@...ell.com, akpm@...l.org
Subject: [PATCH] init_reap_node() initialization fix

It looks like there is a bug in init_reap_node() in slab.c that can
cause multiple oops's on certain ES7000 configurations.  The variable
reap_node is defined per cpu, but only initialized on a single CPU.
This causes an oops in next_reap_node() when __get_cpu_var(reap_node)
returns the wrong value.  Fix is below.


Signed-off-by: Dan Yeisley <dan.yeisley@...sys.com>
---

diff -Naur linux-2.6.19-rc3-org/mm/slab.c linux-2.6.19-rc3-work/mm/slab.c
--- linux-2.6.19-rc3-org/mm/slab.c      2006-10-23 19:02:02.000000000 -0400
+++ linux-2.6.19-rc3-work/mm/slab.c     2006-10-30 11:45:28.000000000 -0500
@@ -883,7 +883,7 @@
        if (node == MAX_NUMNODES)
                node = first_node(node_online_map);
 
-       __get_cpu_var(reap_node) = node;
+       per_cpu(reap_node,cpu) = node;
 }
 
 static void next_reap_node(void)




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/