linux-kernel - Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4546BE24.5000504@sgi.com>
Date:	Mon, 30 Oct 2006 19:08:20 -0800
From:	Jay Lan <jlan@....com>
To:	Oleg Nesterov <oleg@...sign.ru>
CC:	Jay Lan <jlan@...r.sgi.com>, Andrew Morton <akpm@...l.org>,
	Shailabh Nagar <nagar@...son.ibm.com>,
	Balbir Singh <balbir@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xacct_add_tsk: fix pure theoretical ->mm use-after-free

Oleg Nesterov wrote:
> On 10/30, Jay Lan wrote:
>> Oleg Nesterov wrote:
>>> Paranoid fix. The task can free its ->mm after the 'if (p->mm)' check.
>> Why this change is necessary? This routine is indirectly invoked by
>> taskstats_exit_send() routine called inside do_exit():
> 
> Not only, please note
> 
> 	taskstats_user_cmd(TASKSTATS_CMD_ATTR_PID)->fill_pid()->xacct_add_tsk()
> 
> path. This tsk is not 'current', it was found by find_task_by_pid(), and
> it may exit at any time.

OK. Thanks!

Acked-by: Jay Lan <jlan@....com>

> 
> Oleg.
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/