linux-kernel - Re: [PATCH update5] drivers: add LCD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061031155445.02f1aa6b.akpm@osdl.org>
Date:	Tue, 31 Oct 2006 15:54:45 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Miguel Ojeda Sandonis <maxextreme@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH update5] drivers: add LCD support

On Wed, 1 Nov 2006 00:37:48 +0000
Miguel Ojeda Sandonis <maxextreme@...il.com> wrote:

> Andrew, here it is the fifth update for the drivers-add-lcd-support.

It does queue_delayed_work(), but forgot to do cancel_delayed_work().  If
the timer is still pending after module unload, deadly things will happen.

There's a lot of "if(" in there.  Usual kernel style is "if (".

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/