linux-kernel - [PATCH 1/1] Char: isicom, fix tty index check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <1930913791828827916@karneval.cz>
Date:	Tue, 31 Oct 2006 01:36:22 +0100 (CET)
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	<linux-kernel@...r.kernel.org>
Subject: [PATCH 1/1] Char: isicom, fix tty index check

isicom, fix tty index check

Since tty->index is signed and may be < 0, we should assign this to int not
uint. There is already a check to ensure if it is not negative, but
gcc complains with -W flag enabled and it is perfectly correct:
drivers/char/isicom.c:953: warning: comparison of unsigned expression < 0
is always false
Fix this issue by converting `line' variable from uint to int.

Signed-off-by: Jiri Slaby <jirislaby@...il.com>

---
commit d78c239943b72de4f541fcbe178569a78642110e
tree 6ab760f3466acc3f3ef941d18687315d9e75add2
parent d5f297a8d4df43d1d2a5f6146ed2f72a11832abe
author Jiri Slaby <jirislaby@...il.com> Mon, 30 Oct 2006 14:29:32 +0100
committer Jiri Slaby <jirislaby@...il.com> Mon, 30 Oct 2006 14:29:32 +0100

 drivers/char/isicom.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c
index 9a61d0c..18a3a40 100644
--- a/drivers/char/isicom.c
+++ b/drivers/char/isicom.c
@@ -946,8 +946,8 @@ static int isicom_open(struct tty_struct
 {
 	struct isi_port *port;
 	struct isi_board *card;
-	unsigned int line, board;
-	int error;
+	unsigned int board;
+	int error, line;
 
 	line = tty->index;
 	if (line < 0 || line > PORT_COUNT-1)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/