linux-kernel - Re: [PATCH 41/61] x86-64: Fix C3 timer test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611010119.57463.len.brown@intel.com>
Date:	Wed, 1 Nov 2006 01:19:56 -0500
From:	Len Brown <len.brown@...el.com>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>, torvalds@...l.org,
	akpm@...l.org, alan@...rguk.ukuu.org.uk, Andi Kleen <ak@...e.de>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 41/61] x86-64: Fix C3 timer test

Acked-by: Len Brown <len.brown@...el.com>

On Wednesday 01 November 2006 00:34, Chris Wright wrote:
> -stable review patch.  If anyone has any objections, please let us know.
> ------------------
> 
> From: Andi Kleen <ak@...e.de>
> 
> There was a typo in the C3 latency test to decide of the TSC
> should be used or not. It used the C2 latency threshold, not the
> C3 one. Fix that.
> 
> This should fix the time on various dual core laptops.
> 
> Signed-off-by: Andi Kleen <ak@...e.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> Signed-off-by: Chris Wright <chrisw@...s-sol.org>
> 
> ---
>  arch/x86_64/kernel/time.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.18.1.orig/arch/x86_64/kernel/time.c
> +++ linux-2.6.18.1/arch/x86_64/kernel/time.c
> @@ -960,7 +960,7 @@ __cpuinit int unsynchronized_tsc(void)
>   	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) {
>  #ifdef CONFIG_ACPI
>  		/* But TSC doesn't tick in C3 so don't use it there */
> -		if (acpi_fadt.length > 0 && acpi_fadt.plvl3_lat < 100)
> +		if (acpi_fadt.length > 0 && acpi_fadt.plvl3_lat < 1000)
>  			return 1;
>  #endif
>   		return 0;
> 
> --
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/