linux-kernel - Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061101012346.GB27968@stusta.de>
Date:	Wed, 1 Nov 2006 02:23:46 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-usb-devel@...ts.sourceforge.net,
	Randy Dunlap <randy.dunlap@...cle.com>, akpm@...l.org,
	zippel@...ux-m68k.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, link@...gy.org,
	Christoph Hellwig <hch@...radead.org>, torvalds@...l.org,
	greg@...ah.com, toralf.foerster@....de
Subject: Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

On Tue, Oct 31, 2006 at 11:36:52AM -0800, David Brownell wrote:
> 
> > > 		...
> > > 		depends on MII if MII != n
> > > 
> > > except that Kconfig doesn't comprehend conditionals like that.
> > 
> > You can express this in Kconfig:
> > 	depends MII || MII=n
> 
> Except that:
> 
> Warning! Found recursive dependency: USB_USBNET USB_NET_AX8817X MII USB_USBNET
> 
> I think this is another case where Kconfig gets in the way and forces
> introduction of a pseudovariable.  I'll give that a try.
> 
> > But my suggestion was:
> > #if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE))
> >
> > Or simply select MII ...
> 
> Nope; those both prevent completely legit configurations.
> MII is not required, except for those two adapter options.

What should work (with the USB_NET_MCS7830 part from Randy's patch 
removed) together with your patch and the
  #if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE))
is:

config USB_USBNET
        tristate "Multi-purpose USB Networking Framework"
        select MII if USB_NET_AX8817X!=n || USB_NET_MCS7830!=n
	---help---
	  ...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/