linux-kernel - Re: [2.6.19 patch] drivers/block/aoe/aoedev.c: fix NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061101183840.GG27968@stusta.de>
Date:	Wed, 1 Nov 2006 19:38:40 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	"Ed L. Cashin" <ecashin@...aid.com>
Cc:	Alan Cox <alan@...hat.com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6.19 patch] drivers/block/aoe/aoedev.c: fix NULL dereference

On Wed, Nov 01, 2006 at 11:36:28AM -0500, Ed L. Cashin wrote:
> On Wed, Nov 01, 2006 at 01:40:25AM +0100, Adrian Bunk wrote:
> > This patch fixes a NULL dereference introduced by
> > commit e407a7f6cd143b3ab4eb3d7e1cf882e96b710eb5:
> > 
> > This quite unusual error handling through a switch introduces NULL 
> > dereferences if exactly one of the two k{c,z}alloc's failed.
> 
> Hmm.  If exactly one of the two fails, then the value of the switch
> conditional is 1 (well, certainly not zero).  It will jump over the
> zero case, and there's a return in the default case, so I'm having
> trouble seeing the danger.
> 
> What exactly is Coverity saying?  That would be interesting to know.

The Coverity checker was wrong in this case, and I didn't spot it when 
checking since the code is really confusing.

>   Ed L Cashin <ecashin@...aid.com>

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/