linux-kernel - Re: 2.6.19-rc <-> ThinkPads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061101193333.GC9085@mellanox.co.il>
Date:	Wed, 1 Nov 2006 21:33:33 +0200
From:	"Michael S. Tsirkin" <mst@...lanox.co.il>
To:	Linus Torvalds <torvalds@...l.org>
Cc:	Andi Kleen <ak@...e.de>, Ernst Herzberg <earny@...4u.de>,
	Len Brown <lenb@...nel.org>, Adrian Bunk <bunk@...sta.de>,
	Hugh Dickins <hugh@...itas.com>, Pavel Machek <pavel@...e.cz>,
	Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org, linux-pm@...l.org,
	Martin Lorenz <martin@...enz.eu.org>
Subject: Re: 2.6.19-rc <-> ThinkPads

Quoting r. Linus Torvalds <torvalds@...l.org>:
> Subject: Re: 2.6.19-rc <-> ThinkPads
> 
> 
> 
> On Wed, 1 Nov 2006, Andi Kleen wrote:
> >
> > Ok please revert the i386 patch for now then if it fixes the ThinkPads. 
> > The x86-64 version should be probably fixed too, but doesn't cleanly. I will 
> > send you later a patch to fix this there properly.
> 
> Actually, I should have just fixed the ordering. I did some cleanups too, 
> but those are unrelated (except in the sense that I wanted to look at the 
> assembly code, and the cleanups made the code generation at least half-way 
> sane!)
> 
> I've pushed out the changes, but here is the part that may or may not 
> matter for anybody who wants to test it if they don't use git or if it 
> hasn't mirrored out yet. Michael? Martin?

I pulled the latest git, and seems to work for me, thanks.
This still could be a false negative (happened already) so I'll
continue using this, and will post the results.

> Andi: I think the patches should work pretty much as-is for x86-64 too, 
> since all the issues would seem to be similar. 
> 
> I'm not entirely happy with "ioapic_write_entry()" now either (if we 
> change an entry that was already unmasked, we should probably mask it 
> first by writing the low word with the mask bit set, then write the high 
> word, and then write the low word again), but 
> 
>  - this makes us match the ordering we _used_ to have, so if the cleanup 
>    broke things for people, this should unbreak it, and at least not be 
>    any worse than it used to be.
> 
>  - when we write new unmasked entries, they all _should_ have been masked 
>    before, so hopefully the "change a unmasked entry while it's unmasked" 
>    case doesn't actually ever happen. But I didn't actually _check_.
> 
> Somebody should look into that case. Does anybody feel like they want to 
> learn more about the IO-APIC? Halloween is over and gone, but if you want 
> to scare small children _next_ year, telling them about the IO-APIC is 
> likely a good strategy.
> 
> 		Linus

Hmm, sounds interesting :)
Is this a good place to start (I'm feeling lucky hit for IO-APIC)?
http://www.intel.com/design/chipsets/datashts/290566.htm

-- 
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/