[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20061101152715.f1f94d5c.akpm@osdl.org>
Date: Wed, 1 Nov 2006 15:27:15 -0800
From: Andrew Morton <akpm@...l.org>
To: Rusty Russell <rusty@...tcorp.com.au>
Cc: Andi Kleen <ak@....de>, Andi Kleen <ak@...e.de>,
virtualization@...ts.osdl.org, Chris Wright <chrisw@...s-sol.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] paravirtualization: Patch inline replacements for
common paravirt operations.
On Wed, 01 Nov 2006 21:28:13 +1100
Rusty Russell <rusty@...tcorp.com.au> wrote:
> +void apply_paravirt(struct paravirt_patch *start, struct paravirt_patch *end)
> +{
> + struct paravirt_patch *p;
> + int i;
> +
> + for (p = start; p < end; p++) {
> + unsigned int used;
> +
> + used = paravirt_ops.patch(p->instrtype, p->clobbers, p->instr,
> + p->len);
> +#ifdef CONFIG_DEBUG_KERNEL
> + /* Deliberately clobber regs using "not %reg" to find bugs. */
That would be considered to be abusive of CONFIG_DEBUG_KERNEL. A
CONFIG_DEBUG_PARAVIRT which depends on CONFIG_DEBUG_KERNEL would be more
harmonious.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists