linux-kernel - Re: [patch 2/6] Add display output class support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061102205117.GA4887@ucw.cz>
Date:	Thu, 2 Nov 2006 20:51:17 +0000
From:	Pavel Machek <pavel@....cz>
To:	Yu Luming <luming.yu@...il.com>
Cc:	Andrew Morton <akpm@...l.org>, len.brown@...el.com,
	Matt Domsch <Matt_Domsch@...l.com>,
	Alessandro Guido <alessandro.guido@...il.com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	jengelh@...ux01.gwdg.de, gelma@...ma.net, ismail@...dus.org.tr,
	Richard Hughes <hughsient@...il.com>
Subject: Re: [patch 2/6] Add display output class support

Hi!

> Add display output class support
> 
> signed-off-by   Luming.yu@...il.com

Hmm, strange characters inside signoff, and I guessthis should be Real
Name <my@...ess>.


> @@ -0,0 +1,129 @@
> +/*
> + *  output.c - Display output swither driver

Switcher?

> +static ssize_t video_output_store_state(struct class_device *dev,
> +	const char *buf,size_t count)
> +{
> +	char *endp;
> +	struct output_device *od = to_output_device(dev);
> +	int request_state = simple_strtoul(buf,&endp,0);
> +	size_t size = endp - buf;
> +
> +        if (*endp && isspace(*endp))
> +                size++;
> +        if (size != count)
> +                return -EINVAL;

spaces vs. tabs...

> --- /dev/null
> +++ b/include/linux/output.h

I'm not sure if linux/output.h is not little too generic...

							Pavel
-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/