linux-kernel - __alloc_pages() failures reported due to fragmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Nov 2006 07:13:54 -0500
From:	Larry Woodman <lwoodman@...hat.com>
To:	linux-kernel@...r.kernel.org
Subject: __alloc_pages() failures reported due to fragmentation

We have seen a couple of __alloc_pages() failures due to fragmentation, 
there is plenty
of free memory but no large order pages available.  I think the problem 
is in
sock_alloc_send_pskb(), the gfp_mask includes __GFP_REPEAT but its never
used/passed to the page allocator.  Shouldnt the gfp_mask be passed to 
alloc_skb() ?

-------------------------------------------------------------------
struct sk_buff *sock_alloc_send_pskb()
{
       unsigned int gfp_mask;
... 
                                                                          
       gfp_mask = sk->sk_allocation;
       if (gfp_mask & __GFP_WAIT)
               gfp_mask |= __GFP_REPEAT;
...
       skb = alloc_skb(header_len, sk->sk_allocation);
--------------------------------------------------------------------


--- linux-2.6.18.noarch/net/core/sock.c.orig
+++ linux-2.6.18.noarch/net/core/sock.c
@@ -1154,7 +1154,7 @@ static struct sk_buff *sock_alloc_send_p
 			goto failure;
 
 		if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) {
-			skb = alloc_skb(header_len, sk->sk_allocation);
+			skb = alloc_skb(header_len, gfp_mask);
 			if (skb) {
 				int npages;
 				int i;



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/