linux-kernel - Re: [PATCH 2/3] fsstack: Generic get/set lower object functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0611031735070.21864@yvahk01.tjqt.qr>
Date:	Fri, 3 Nov 2006 17:36:03 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Pekka Enberg <penberg@...helsinki.fi>
cc:	Trond Myklebust <trond.myklebust@....uio.no>,
	Josef Sipek <jsipek@....cs.sunysb.edu>,
	Mark Williamson <mark.williamson@...cam.ac.uk>,
	linux-kernel@...r.kernel.org,
	Michael Halcrow <mhalcrow@...ibm.com>,
	Erez Zadok <ezk@...sunysb.edu>,
	Christoph Hellwig <hch@...radead.org>,
	Al Viro <viro@....linux.org.uk>, Andrew Morton <akpm@...l.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/3] fsstack: Generic get/set lower object functions


>> Why? What is so special about the details that you need to hide them?
>> This is a union that will always be part of a structure anyway.
>
> Nothing. Josef, I think we should make them unions.

In other words,

/* structs to maintain pointers to the lower VFS objects */
struct fsstack_sb_info {
	union {
		struct super_block *sb;
		struct super_block **sbs;
	};                                                                      
};                                                                         

should become:

union fsstack_sb_info {
	struct super_block *sb;
	struct super_block **sbs;
};


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/