linux-kernel - Re: [PATCH] bdev: fix ->bd_part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17738.50949.287850.74986@cse.unsw.edu.au>
Date:	Fri, 3 Nov 2006 15:35:17 +1100
From:	Neil Brown <neilb@...e.de>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] bdev: fix ->bd_part_count leak

On Thursday November 2, a.p.zijlstra@...llo.nl wrote:
> 
> Don't leak a ->bd_part_count when the partition open fails with -ENXIO.
> 

Acked-by: NeilBrown <neilb@...e.de>

Thanks.  It took me a while to see why that was a correct fix.  I
wasn't noticing the 'if (bdev != bdev->bd_contains)' which is only
true after __blkdev_get(whole, ...., 1) has been called.

NeilBrown

> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> ---
>  fs/block_dev.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6-mm/fs/block_dev.c
> ===================================================================
> --- linux-2.6-mm.orig/fs/block_dev.c
> +++ linux-2.6-mm/fs/block_dev.c
> @@ -907,6 +907,7 @@ EXPORT_SYMBOL(bd_set_size);
>  
>  static int __blkdev_get(struct block_device *bdev, mode_t mode, unsigned flags,
>  			int for_part);
> +static int __blkdev_put(struct block_device *bdev, int for_part);
>  
>  static int do_open(struct block_device *bdev, struct file *file, int for_part)
>  {
> @@ -992,7 +993,7 @@ out_first:
>  	bdev->bd_disk = NULL;
>  	bdev->bd_inode->i_data.backing_dev_info = &default_backing_dev_info;
>  	if (bdev != bdev->bd_contains)
> -		blkdev_put(bdev->bd_contains);
> +		__blkdev_put(bdev->bd_contains, 1);
>  	bdev->bd_contains = NULL;
>  	put_disk(disk);
>  	module_put(owner);
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/