lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 04 Nov 2006 22:18:25 +0059 From: Jiri Slaby <jirislaby@...il.com> To: Mariusz Kozlowski <m.kozlowski@...land.pl> CC: Alan Cox <alan@...rguk.ukuu.org.uk>, Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2.6.19-rc4-mm2] epca get_termio cleanup Mariusz Kozlowski wrote: > Hello, > > The code using get_termio was already '#if 0' but get_termio itself was not. You would rather wipe it out or better, wipe the whole driver out, we have an ack from Digi ;). > Hence the warning: > drivers/char/epca.c:2744: warning: 'get_termio' defined but not used > > Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl> > > diff -up linux-2.6.19-rc4-orig/drivers/char/epca.c > linux-2.6.19-rc4/drivers/char/epca.c > --- linux-2.6.19-rc4-orig/drivers/char/epca.c 2006-11-04 20:31:54.000000000 > +0100 > +++ linux-2.6.19-rc4/drivers/char/epca.c 2006-11-04 21:27:50.000000000 > +0100 > @@ -209,7 +209,9 @@ static void digi_send_break(struct chann > static void setup_empty_event(struct tty_struct *tty, struct channel *ch); > void epca_setup(char *, int *); > > +#if 0 > static int get_termio(struct tty_struct *, struct termio __user *); > +#endif > static int pc_write(struct tty_struct *, const unsigned char *, int); > static int pc_init(void); > static int init_PCI(void); > @@ -2740,10 +2742,12 @@ static void setup_empty_event(struct tty > > /* --------------------- Begin get_termio ----------------------- */ > > +#if 0 > static int get_termio(struct tty_struct * tty, struct termio __user * termio) > { /* Begin get_termio */ > return kernel_termios_to_user_termio(termio, tty->termios); > } /* End get_termio */ > +#endif > > /* ---------------------- Begin epca_setup -------------------------- */ > void epca_setup(char *str, int *ints) regards, -- http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists