linux-kernel - Re: [PATCH 30/61] knfsd: Fix race that can disable NFS server.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17742.31232.907908.330955@cse.unsw.edu.au>
Date:	Mon, 6 Nov 2006 10:55:44 +1100
From:	Neil Brown <neilb@...e.de>
To:	Willy Tarreau <w@....eu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 30/61] knfsd: Fix race that can disable NFS server.

On Saturday November 4, w@....eu wrote:
> Hi Neil, 
> 
> I don't know if you noticed my request for ACK as I did not get any
> response. I think that your patch here is a good candidate for 2.4
> too, I would just like to get your confirmation before merging it.

Sorry, I went to grab a copy of the latest 2.4 to double-check and the
got distracted.

Yes: this patch is definitely appropriate for 2.4.

Thanks,
NeilBrown

> > ---
> >  net/sunrpc/svcsock.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2.6.18.1.orig/net/sunrpc/svcsock.c
> > +++ linux-2.6.18.1/net/sunrpc/svcsock.c
> > @@ -902,7 +902,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
> >  		return 0;
> >  	}
> >  
> > -	if (test_bit(SK_CONN, &svsk->sk_flags)) {
> > +	if (svsk->sk_sk->sk_state == TCP_LISTEN) {
> >  		svc_tcp_accept(svsk);
> >  		svc_sock_received(svsk);
> >  		return 0;
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/