linux-kernel - Re: [rfc patch] i386: don't save eflags on task switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 04 Nov 2006 20:17:44 -0800
From:	Zachary Amsden <zach@...are.com>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	Chuck Ebbert <76306.1226@...puserve.com>,
	Linus Torvalds <torvalds@...l.org>, Andi Kleen <ak@...e.de>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [rfc patch] i386: don't save eflags on task switch

Benjamin LaHaise wrote:
> On Sat, Nov 04, 2006 at 11:09:42AM -0800, Zachary Amsden wrote:
>   
>> Every processor I've ever measured it on, popf is slower.  On P4, for 
>> example, pushf is 6 cycles, and popf is 54.  On Opteron, it is 2 / 12.  
>> On Xeon, it is 7 / 91.
>>     
>
> pushf has to wait until all flag dependancies can be resolved.  On the 
> P4 with >100 instructions in flight, that can take a long time.  Popf 
> on the other hand has no dependancies on outstanding instructions as it 
> resets the machine state.
>   

Yes, but as Linus points out popf is most likely microcoded, thus much 
slower.  Flag dependency is not unique to pushf, many much more common 
instructions (adc, jcc, sbc, cmovcc, movs, stos, ...) have flag 
dependencies, which can still be pipeline forwarded.  I think the raw 
cycle counts speak for themselves, despite the fact that I only measured 
instruction latency, not throughput.  Using a branch to eliminate a 
pushf is thus probably not a win in most cases.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/