linux-kernel - Re: lib/iomap.c mmio_{in,out}s* vs. __raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1162704529.28571.164.camel@localhost.localdomain>
Date:	Sun, 05 Nov 2006 16:28:48 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linus Torvalds <torvalds@...l.org>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Jeff Garzik <jgarzik@...ox.com>, Andrew Morton <akpm@...l.org>,
	"David S. Miller" <davem@...emloft.net>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: lib/iomap.c mmio_{in,out}s* vs. __raw_* accessors

On Sun, 2006-11-05 at 16:08 +1100, Benjamin Herrenschmidt wrote:
> > Can you work based on something like this instead?
> > 
> > (Totally untested, I just did this as an example of what I think is a lot 
> > more maintainable)
> 
> Yup, that would definitely work for me.
> 
> I'll do the same for the repeat ops..

I'm blind, didn't see you did it for them already :-)

Ok, your patch builds fine here. I can't test at the moment as I don't
have a machine at hand that has a device whose driver uses the ops in
iomap though, but I can't see any reason why it wouldn't work if it
builds, so as far as I'm concerned, that's good to go in 2.6.20.
(earlier if you wish but I won't submit the patch doing the powerpc
changes that makes me use those change before 2.6.20 obviously :-)

Cheers,
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/