linux-kernel - Re: Fw: Top 100 inline functions (make allyesconfig) was Re: [ANNOUNCE] pahole and other DWARF2 utilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 05 Nov 2006 14:32:17 +0800
From:	David Woodhouse <dwmw2@...radead.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	Arnaldo Carvalho de Melo <acme@...driva.com>,
	linux-kernel@...r.kernel.org, lwn@....net,
	linux-mtd@...ts.infradead.org
Subject: Re: Fw: Top 100 inline functions (make allyesconfig) was Re:
	[ANNOUNCE] pahole and other DWARF2 utilities

On Sat, 2006-11-04 at 13:20 -0800, Andrew Morton wrote:
> cfi_build_cmd() is nutty. 

Damn right it's nutty. Imagine the number of ways you can wire up 1-8
flash chips in either 8-bit or 16-bit mode to a bus which is between 8
and 64 bits wide. Deal with it in software, with a "chip driver"
abstraction which knows what data to put at which address on each
_chip_, and which needs to calculate the corresponding bus data/address.

In the sensible case where you build in support for what you have -- one
interleave, one mode, one bus size -- it's simple. And that's why it's
inline. This is one of the cases where 'allyesconfig' just doesn't make
much sense.

I'm not entirely averse to taking it out-of-line, but show me data on
the interesting case rather than the allyesconfig case.

And tell me about it in about two weeks' time when the sky stops falling
on my head and I get to go home. :)

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/