[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20061105.002237.18309940.davem@davemloft.net>
Date: Sun, 05 Nov 2006 00:22:37 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: hch@....de
Cc: davej@...hat.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/3] add dev_to_node()
From: Christoph Hellwig <hch@....de>
Date: Sun, 5 Nov 2006 00:53:23 +0100
> On Sat, Nov 04, 2006 at 06:06:48PM -0500, Dave Jones wrote:
> > On Sat, Nov 04, 2006 at 11:56:29PM +0100, Christoph Hellwig wrote:
> >
> > This will break the compile for !NUMA if someone ends up doing a bisect
> > and lands here as a bisect point.
> >
> > You introduce this nice wrapper..
>
> The dev_to_node wrapper is not enough as we can't assign to (-1) for
> the non-NUMA case. So I added a second macro, set_dev_node for that.
>
> The patch below compiles and works on numa and non-NUMA platforms.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
Looks good to me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists