lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 06 Nov 2006 13:15:02 -0000 From: Avi Kivity <avi@...ranet.com> To: kvm-devel@...ts.sourceforge.net Cc: Christian Hesse <mail@...thworm.de>, linux-kernel@...r.kernel.org, akpm@...l.org Subject: [PATCH] KVM: fix calculation of initial value of rdx register On bootup, the rdx register contains information about the processor. The function which calculates this value has the bugs: - missing 'cpuid' to get the value from the processor - missing register clobber caused a miscompilation in some circumstances - we shouldn't return a value that depends on the current processor in case we migrate In any case nobody looks at the value, so just return a generic P6 identifier. Thanks to Christian Hesse <mail@...thworm.de> for debugging help. Signed-off-by: Avi Kivity <avi@...ranet.com> Index: linux-2.6/drivers/kvm/kvm_main.c =================================================================== --- linux-2.6.orig/drivers/kvm/kvm_main.c +++ linux-2.6/drivers/kvm/kvm_main.c @@ -1052,12 +1052,7 @@ static void set_cr8(struct kvm_vcpu *vcp static u32 get_rdx_init_val(void) { - u32 val; - - asm ("movl $1, %%eax \n\t" - "movl %%eax, %0 \n\t" : "=g"(val) ); - return val; - + return 0x600; /* P6 family */ } static void fx_init(struct kvm_vcpu *vcpu) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists