linux-kernel - Re: [PATCH] e1000: Fix regression: garbled stats and irq allocation during swsusp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <454F5703.7040209@intel.com>
Date:	Mon, 06 Nov 2006 07:38:43 -0800
From:	Auke Kok <auke-jan.h.kok@...el.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	torvalds@...l.org, linux-kernel@...r.kernel.org, greg@...ah.com,
	stable@...r.kernel.org, rjw@...k.pl, bunk@...sta.de, akpm@...l.org,
	laurent.riffard@...e.fr, rajesh.shah@...el.com,
	toralf.foerster@....de, pavel@....cz, jesse.brandeburg@...el.com,
	"Ronciak, John" <john.ronciak@...el.com>,
	"John W. Linville" <linville@...driver.com>, nhorman@...hat.com,
	cluebot@...orafaq.org, notting@...hat.com, bruce.w.allan@...el.com,
	davej@...hat.com, linville@...hat.com, wtogami@...hat.com,
	dag@...ers.com, error27@...il.com,
	e1000-list <e1000-devel@...ts.sourceforge.net>
Subject: Re: [PATCH] e1000: Fix regression: garbled stats and irq allocation
 during swsusp

Jeff Garzik wrote:
> Auke Kok wrote:
>>
>> e1000: Fix regression: garbled stats and irq allocation during swsusp
>>
>> After 7.0.33/2.6.16, e1000 suspend/resume left the user with an enabled
>> device showing garbled statistics and undetermined irq allocation state,
>> where `ifconfig eth0 down` would display `trying to free already freed 
>> irq`.
>>
>> Explicitly free and allocate irq as well as powerup the PHY during resume
>> fixes.
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> 
> ACK, but:
> 
> Applying 'e1000: Fix regression: garbled stats and irq allocation during 
> swsusp'
> 
> fatal: corrupt patch at line 8


There's another problem with it, that needs attention as well. I will reformat and 
re-post the patch to everyone.

Cheers,

Auke


From: <chrisw@...s-sol.org>
Also, would this cause a problem if I ifdown the interface to call
->close then suspend?  Looks like it'd free_irq twice, maybe need a
netif_running() check?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/