linux-kernel - Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaslgwo6xn.fsf@cisco.com>
Date:	Mon, 06 Nov 2006 08:50:44 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linuxppc-dev@...abs.org, Hoang-Nam Nguyen <hnguyen@...ibm.com>,
	rolandd@...co.com, raisch@...ibm.com, linux-kernel@...r.kernel.org,
	openib-general@...nib.org
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

 > I'd simply move the memset into the alloc function and get rid of the
 > constructor here.

Slightly better still would be to use kmem_cache_zalloc() (save a tiny
bit of text by getting rid of the call to memset).

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/