linux-kernel - Re: [patch] Regression in 2.6.19-rc microcode driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <454F86DE.1040803@linux.intel.com>
Date:	Mon, 06 Nov 2006 20:02:54 +0100
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Andrew Morton <akpm@...l.org>
CC:	linux-kernel@...r.kernel.org, shaohua.li@...el.com, bunk@...sta.de
Subject: Re: [patch] Regression in 2.6.19-rc microcode driver

Andrew Morton wrote:
>> --- linux-2.6.18/arch/i386/kernel/microcode.c.org	2006-11-06 14:50:37.000000000 +0100
>> +++ linux-2.6.18/arch/i386/kernel/microcode.c	2006-11-06 14:52:30.000000000 +0100
>> @@ -577,7 +577,7 @@ static void microcode_init_cpu(int cpu)
>>  	set_cpus_allowed(current, cpumask_of_cpu(cpu));
>>  	mutex_lock(&microcode_mutex);
>>  	collect_cpu_info(cpu);
>> -	if (uci->valid)
>> +	if (uci->valid && system_state==SYSTEM_RUNNING)
>>  		cpu_request_microcode(cpu);
>>  	mutex_unlock(&microcode_mutex);
>>  	set_cpus_allowed(current, old);
> 
> Can we fix this by switching to late_initcall() or something like that?

I will try but it then still runs before userspace (esp "init") is 
alive so I'm not convinced it'll do the right thing
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/