linux-kernel - Re: [ckrm-tech] [PATCH 6/6] Resource Groups over generic containers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <454EC32F.2010004@in.ibm.com>
Date:	Mon, 06 Nov 2006 10:37:59 +0530
From:	Balbir Singh <balbir@...ibm.com>
To:	Paul Jackson <pj@....com>
CC:	sekharan@...ibm.com, ckrm-tech@...ts.sourceforge.net, jlan@....com,
	Simon.Derr@...l.net, linux-kernel@...r.kernel.org,
	mbligh@...gle.com, winget@...gle.com, rohitseth@...gle.com,
	menage@...gle.com
Subject: Re: [ckrm-tech] [PATCH 6/6] Resource Groups over generic containers

Paul Jackson wrote:
> Balbir wrote:
>> This should be kmalloc(nbytes), an echo ".." has a "\n" associated
>> with it.
> 
> But a:
>   write(1, "..", 2);
> does not have a trialing newline.

Yes, true.

> 
> If some consumer of this kernel buffer copy of what the
> user wrote cannot handle the possible trailing whitespace,
> they will have to chomp (Perl phrase) it off.  You can't
> just whack one byte blindly.
> 

Yes, agreed.

> At least for the kernel/cpuset.c code, from whence this
> came, the consumers of this kernel buffer copy are such
> routines as simple_strtoul() and cpulist_parse(), both
> of which cope with trailing newlines.
> 

The problem I have is that match_token() that's used by
the resource group's infrastructure cannot deal with
"\n". I think the code needs in res_groups needs to
get smarter like the code in simple_strtoul()


-- 
	Thanks for the feedback,
	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/